-
Notifications
You must be signed in to change notification settings - Fork 25.5k
rest-api-spec: remove required: false for query parameters #134658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vast majority of query parameters are not required, but most of them don't specify it. Removing "required": false entirely will help generation.
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mosche
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
💔 Backport failed
You can use sqren/backport to manually backport by running |
pquentin
added a commit
to pquentin/elasticsearch
that referenced
this pull request
Sep 17, 2025
pquentin
added a commit
to pquentin/elasticsearch
that referenced
this pull request
Sep 17, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Sep 17, 2025
…34658) The vast majority of query parameters are not required, but most of them don't specify it. Removing "required": false entirely will help generation.
pquentin
added a commit
to pquentin/elasticsearch
that referenced
this pull request
Sep 17, 2025
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
…34658) The vast majority of query parameters are not required, but most of them don't specify it. Removing "required": false entirely will help generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
backport pending
:Core/Infra/REST API
REST infrastructure and utilities
>non-issue
Team:Core/Infra
Meta label for core/infra team
v8.19.5
v9.1.5
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vast majority of query parameters are not required, but most of them don't specify it. Removing "required": false entirely will help generate the rest-api-spec from the Elasticsearch specification by just not including it when not needed.
This was done using this Python script: